Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 4024003: Clean up the log-stack-tracer test.... (Closed)

Created:
10 years, 2 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Clean up the log-stack-tracer test. Create the functions using the normal API and remove some unnecessary helpers. Committed: http://code.google.com/p/v8/source/detail?r=5688

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -30 lines) Patch
M test/cctest/test-log-stack-tracer.cc View 1 3 chunks +6 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
10 years, 2 months ago (2010-10-21 14:07:14 UTC) #1
Søren Thygesen Gjesse
LGTM
10 years, 2 months ago (2010-10-21 14:18:09 UTC) #2
mnaganov (inactive)
10 years, 2 months ago (2010-10-21 19:23:00 UTC) #3
On 2010/10/21 14:07:14, fschneider wrote:
> 

Thank you very much, Florian!

Powered by Google App Engine
This is Rietveld 408576698