Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/log.h

Issue 40219: Get rid or heap allocation in stack sampler to avoid deadlocks. (Closed)
Patch Set: CHECK(a > b) -> CHECK_GT Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/log.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 }; 270 };
271 271
272 272
273 // Class that extracts stack trace, used for profiling 273 // Class that extracts stack trace, used for profiling
274 class StackTracer BASE_EMBEDDED { 274 class StackTracer BASE_EMBEDDED {
275 public: 275 public:
276 explicit StackTracer(unsigned int low_stack_bound) 276 explicit StackTracer(unsigned int low_stack_bound)
277 : low_stack_bound_(low_stack_bound) { } 277 : low_stack_bound_(low_stack_bound) { }
278 void Trace(TickSample* sample); 278 void Trace(TickSample* sample);
279 private: 279 private:
280 // Maximum number of stack frames to capture
281 static const int kMaxStackFrames = 5;
282 280
283 unsigned int low_stack_bound_; 281 unsigned int low_stack_bound_;
284 }; 282 };
285 283
286 284
287 } } // namespace v8::internal 285 } } // namespace v8::internal
288 286
289 #endif // V8_LOG_H_ 287 #endif // V8_LOG_H_
OLDNEW
« no previous file with comments | « no previous file | src/log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698