Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 40219: Get rid or heap allocation in stack sampler to avoid deadlocks. (Closed)

Created:
11 years, 9 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Get rid or heap allocation in stack sampler to avoid deadlocks. Committed: http://code.google.com/p/v8/source/detail?r=1440

Patch Set 1 #

Patch Set 2 : CHECK(a > b) -> CHECK_GT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -45 lines) Patch
M src/log.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/log.cc View 2 chunks +11 lines, -21 lines 0 comments Download
M src/platform.h View 1 chunk +3 lines, -20 lines 0 comments Download
M test/cctest/test-log-ia32.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mikhail Naganov
11 years, 9 months ago (2009-03-06 12:22:17 UTC) #1
Søren Thygesen Gjesse
11 years, 9 months ago (2009-03-06 13:02:00 UTC) #2
LGTM

On 2009/03/06 12:22:17, Mikhail Naganov wrote:
>

Powered by Google App Engine
This is Rietveld 408576698