Issue 40213: Reverting 11102....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40213: Reverting 11102.... (Closed)

Created:
11 years, 9 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Reverting 11102. Used git svn dcommit instead of git cl dcommit by mistake. Reverting to re-commit properly. TBR=erikkay

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -10 lines)			Patch
	M	base/file_util_posix.cc	View		3 chunks	+3 lines, -6 lines	0 comments	Download
	M	base/test_file_util_posix.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

11 years, 9 months ago (2009-03-06 09:53:05 UTC) #2

TBR

If there is better way to handle situations like this (accidental git svn
dcommit), please let me know. I think that a commit (r11102) with bad commit
message and no review is suspicious and confusing.

Expand Messages | Collapse Messages