Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4772)

Unified Diff: chrome/browser/worker_host/message_port_dispatcher.h

Issue 402106: Fix unitialized memory access in workers. (Closed)
Patch Set: It is "#else" not "#lse" :(. Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/worker_host/message_port_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/worker_host/message_port_dispatcher.h
diff --git a/chrome/browser/worker_host/message_port_dispatcher.h b/chrome/browser/worker_host/message_port_dispatcher.h
index 21be0c6142a34e5be2971465e544f9c854e99c4b..16f4d22f1aff4e4fd8089a0a4a4384ce65d1978d 100644
--- a/chrome/browser/worker_host/message_port_dispatcher.h
+++ b/chrome/browser/worker_host/message_port_dispatcher.h
@@ -67,6 +67,16 @@ class MessagePortDispatcher : public NotificationObserver {
const NotificationSource& source,
const NotificationDetails& details);
+ // Handles the details of removing a message port id. Before calling this,
+ // verify that the message port id exists.
+ void Erase(int message_port_id);
+
+#ifdef NDEBUG
+ bool CheckMessagePortMap(bool check_entanglements) { }
+#else
+ bool CheckMessagePortMap(bool check_entanglements);
+#endif
+
struct MessagePort {
// sender and route_id are what we need to send messages to the port.
IPC::Message::Sender* sender;
« no previous file with comments | « no previous file | chrome/browser/worker_host/message_port_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698