Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 402104: Convert memory_test to use the common stats-reporting methods in UITest.... (Closed)

Created:
11 years, 1 month ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews_googlegroups.com, Paweł Hajdan Jr., jar (doing other things)
Visibility:
Public.

Description

Convert memory_test to use the common stats-reporting methods in UITest. This adds IO stats to memory_test, and renames most of the memory_test traces to match the names used by page_cycler so that (after the historical memory_ data is converted) we can do apples-to-apples comparisons of stats across all the tests that use these methods. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32632

Patch Set 1 #

Patch Set 2 : typo fix #

Total comments: 4

Patch Set 3 : add stat for maximum single peak renderer size #

Patch Set 4 : make the commit_charge unimportant so page load time is displayed on the default overview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -228 lines) Patch
M chrome/test/memory_test/memory_test.cc View 6 chunks +10 lines, -129 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 1 2 3 4 chunks +191 lines, -99 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sgk
If this is all right, I'd convert memory_test stats by hand to preserve history. I'm ...
11 years, 1 month ago (2009-11-20 00:09:06 UTC) #1
Mike Belshe
http://codereview.chromium.org/402104/diff/3001/4002 File chrome/test/ui/ui_test.cc (right): http://codereview.chromium.org/402104/diff/3001/4002#newcode1337 Line 1337: browser_peak_virtual_size += peak_virtual_size; do you really want to ...
11 years, 1 month ago (2009-11-20 10:27:13 UTC) #2
sgk
http://codereview.chromium.org/402104/diff/3001/4002 File chrome/test/ui/ui_test.cc (right): http://codereview.chromium.org/402104/diff/3001/4002#newcode1337 Line 1337: browser_peak_virtual_size += peak_virtual_size; On 2009/11/20 10:27:13, Mike Belshe ...
11 years, 1 month ago (2009-11-20 17:25:36 UTC) #3
Mike Belshe
11 years, 1 month ago (2009-11-20 18:20:37 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698