Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 402091: Fix tab focus/blur events on tab switch on the Mac (Closed)

Created:
11 years, 1 month ago by jcampan
Modified:
9 years, 7 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Ensures the renderer gets focus/blur message when switching tabs. BUG=26610 TEST=Open a page in a teb that prints out when the window object gets focused blured. Switch to another tab then come back to that tab. A blur and focus events should have been fired. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32696

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M chrome/browser/cocoa/tab_contents_controller.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/tab_contents_controller.mm View 1 4 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/tab_strip_controller.mm View 1 2 3 4 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jcampan
11 years, 1 month ago (2009-11-19 20:21:11 UTC) #1
John Grabowski
11 years, 1 month ago (2009-11-19 21:03:45 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698