Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2388)

Unified Diff: chrome/plugin/plugin_channel_base.h

Issue 402072: Merge 32397 - Only clears the unblock flag on sync IPCs during other sync dis... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/249/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/plugin/plugin_channel.cc ('k') | chrome/plugin/plugin_channel_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/plugin/plugin_channel_base.h
===================================================================
--- chrome/plugin/plugin_channel_base.h (revision 32429)
+++ chrome/plugin/plugin_channel_base.h (working copy)
@@ -85,8 +85,8 @@
virtual void OnChannelError();
// If this is set, sync messages that are sent will only unblock the receiver
- // if this channel is in the middle of a dispatch.
- void SendUnblockingOnlyDuringDispatch();
+ // if this channel is in the middle of a sync dispatch.
+ void SendUnblockingOnlyDuringSyncDispatch();
virtual bool Init(MessageLoop* ipc_message_loop, bool create_pipe_now);
@@ -114,13 +114,13 @@
// error. This flag is used to indicate the same.
bool channel_valid_;
- // Track whether we're within a dispatch; works like a refcount, 0 when we're
- // not.
- int in_dispatch_;
+ // Track whether we're within a synchronous dispatch; works like a refcount,
+ // 0 when we're not.
+ int in_sync_dispatch_;
// If true, sync messages will only be marked as unblocking if the channel is
- // in the middle of dispatching a message.
- bool send_unblocking_only_during_dispatch_;
+ // in the middle of dispatching a synchronous message.
+ bool send_unblocking_only_during_sync_dispatch_;
DISALLOW_COPY_AND_ASSIGN(PluginChannelBase);
};
« no previous file with comments | « chrome/plugin/plugin_channel.cc ('k') | chrome/plugin/plugin_channel_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698