Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 402056: Fix crash in string replace with regexp. If the suffix of the subject... (Closed)

Created:
11 years, 1 month ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Fix crash in string replace with regexp. If the suffix of the subject string is larger than 2047 chars we will encode the slice as two Smis instead of one. The calculation of the max size of the string builder did not take this into account. BUG=http://code.google.com/p/v8/issues/detail?id=515 Committed: http://code.google.com/p/v8/source/detail?r=3334

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -4 lines) Patch
M src/runtime.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-515.js View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
11 years, 1 month ago (2009-11-18 18:28:44 UTC) #1
Mads Ager (chromium)
New snapshot uploaded. The same problem exists when encoding the previous string as two Smis ...
11 years, 1 month ago (2009-11-18 18:44:17 UTC) #2
Kasper Lund
11 years, 1 month ago (2009-11-18 18:46:18 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698