Prep for printing common memory stats from page_cycler_tests and memory_test:...

Prep for printing common memory stats from page_cycler_tests and memory_test:
Move PrintIOPerfInfo(), PrintMemoryUsageInfo() and PrintSystemCommitCharge()
into the UITest base class so both page_cycler and memory_test will be
able to use them.  Make the user data dir a parameter so that memory_test
will be able to point to its temporary copy.
BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32538

[sgk, 2009-11-18 17:43:18]

I'm not 100% sold on moving these here; if there's a better pattern, let me
know.  If this passes muster, the next CL would convert memory_test to use these
instead of its separate copies.

[sgk, 2009-11-19 14:16:38]

ping

[Mike Belshe, 2009-11-19 16:57:34]

lgmt

http://codereview.chromium.org/402052/diff/3001/4002
File chrome/test/ui/ui_test.cc (right):

http://codereview.chromium.org/402052/diff/3001/4002#newcode1190
Line 1190: NOTREACHED();
this is just a DCHECK(false).  I think you should return as well.  (otherwise
this will crash later, right?)

http://codereview.chromium.org/402052/diff/3001/4002#newcode1193
Line 1193: scoped_ptr<base::ProcessMetrics> process_metrics;
nit:  you could merge lines 1193 & 1194

http://codereview.chromium.org/402052/diff/3001/4002#newcode1258
Line 1258: NOTREACHED();
nit: same thing - should return.

[sgk, 2009-11-19 19:04:07]

http://codereview.chromium.org/402052/diff/3001/4002
File chrome/test/ui/ui_test.cc (right):

http://codereview.chromium.org/402052/diff/3001/4002#newcode1190
Line 1190: NOTREACHED();
On 2009/11/19 16:57:34, Mike Belshe wrote:
> this is just a DCHECK(false).  I think you should return as well.  (otherwise
> this will crash later, right?)

Done.

http://codereview.chromium.org/402052/diff/3001/4002#newcode1193
Line 1193: scoped_ptr<base::ProcessMetrics> process_metrics;
On 2009/11/19 16:57:34, Mike Belshe wrote:
> nit:  you could merge lines 1193 & 1194

Done.

http://codereview.chromium.org/402052/diff/3001/4002#newcode1258
Line 1258: NOTREACHED();
On 2009/11/19 16:57:34, Mike Belshe wrote:
> nit: same thing - should return.

Done.