Issue 402029: Don't allow content scripts to execute on file:// urls....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 402029: Don't allow content scripts to execute on file:// urls.... (Closed)

Created:
11 years, 1 month ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
USE chromium.org ACCOUNT, Matt Perry

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't allow content scripts to execute on file:// urls. This requires a command line flag for the page cycler tests, since those load file:// urls. BUG=27877 TEST=Bunch of tests affected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32271

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+230 lines, -209 lines)			Patch
M	chrome/browser/extensions/extension_browsertests_misc.cc	View	1 2 3	8 chunks	+25 lines, -28 lines	0 comments	Download
M	chrome/browser/extensions/extension_startup_unittest.cc	View	1 2 3	1 chunk	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service_unittest.cc	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/stubs_apitest.cc	View	1 2 3	1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/user_script_listener_unittest.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2 3	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/content_scripts.html	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/static/content_scripts.html	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 2 3	2 chunks	+12 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.cc	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/stubs/manifest.json	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/browsertest/title_localized_pa/manifest.json	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
MM	chrome/test/data/extensions/good/Extensions/bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0/manifest.json	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/good/Preferences	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
MM	chrome/test/data/extensions/profiles/content_scripts1/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
MM	chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/ahbojlbmpfcbogfblmekncilheldhjga/1.0/manifest.json	View	1 2 3	1 chunk	+10 lines, -10 lines	0 comments	Download
MM	chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/coomonpcecmahbfkifeohkbgicpcfdgf/1.0/manifest.json	View	1 2 3	1 chunk	+10 lines, -10 lines	0 comments	Download
MM	chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/dhminefdpfgdedodgdilagiencggdcpm/1.0/manifest.json	View	1 2 3	1 chunk	+10 lines, -10 lines	0 comments	Download
MM	chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/kgfhjcinicjnlcbnbacbkbjdbafnlckn/1.0/manifest.json	View	1 2 3	1 chunk	+10 lines, -10 lines	0 comments	Download
MM	chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/ledhkldokbafdcbmepdigjmkabmombel/1.0/manifest.json	View	1 2 3	1 chunk	+10 lines, -10 lines	0 comments	Download
MM	chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/lgmapeiimomfdbfphldobhhpoaoafaci/1.0/manifest.json	View	1 2 3	1 chunk	+10 lines, -10 lines	0 comments	Download
MM	chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/maemolkcfjifpmigoecmpfphmebnebpk/1.0/manifest.json	View	1 2 3	1 chunk	+10 lines, -10 lines	0 comments	Download
MM	chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/mdeggakgacjccnbfbhbihfchoidihkaf/1.0/manifest.json	View	1 2 3	1 chunk	+10 lines, -10 lines	0 comments	Download
MM	chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/mgonfebmjopdoipblbijejncibmgmcol/1.0/manifest.json	View	1 2 3	1 chunk	+10 lines, -10 lines	0 comments	Download
MM	chrome/test/data/extensions/profiles/content_scripts10/Default/Extensions/ohmmlgjlmaadhojogadklhlidfpdeoca/1.0/manifest.json	View	1 2 3	1 chunk	+10 lines, -10 lines	0 comments	Download
MM	chrome/test/data/extensions/profiles/content_scripts50/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json	View	1 2 3	1 chunk	+50 lines, -50 lines	0 comments	Download
M	chrome/test/data/extensions/subscribe_page_action/manifest.json	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/page_cycler/page_cycler_test.cc	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

Sorry to drop this on you, but I believe most of the tests affected are ...

11 years, 1 month ago (2009-11-17 22:36:00 UTC) #1

LGTM

Expand Messages | Collapse Messages