Issue 402012: Accelerate charCodeAt on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 402012: Accelerate charCodeAt on ARM. (Closed)

Created:
11 years, 1 month ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Accelerate charCodeAt on ARM. Committed: http://code.google.com/p/v8/source/detail?r=3327

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -48 lines)			Patch
M	src/arm/codegen-arm.cc	View	1 chunk	+74 lines, -0 lines	1 comment	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/mjsunit/string-charcodeat.js	View	7 chunks	+50 lines, -47 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

11 years, 1 month ago (2009-11-18 10:04:08 UTC) #2

LGTM

http://codereview.chromium.org/402012/diff/1/4
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/402012/diff/1/4#newcode3330
Line 3330: ASSERT_EQ(1, kSmiTagSize);
Might also want to assert that kSmiShiftSize is zero (it always is on 32-bit,
but then again, kSmiTagSize is always 1).

Expand Messages | Collapse Messages