Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1353)

Issue 402008: Speed up charCodeAt on very large cons strings, by insisting on... (Closed)

Created:
11 years, 1 month ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Speed up charCodeAt on very large cons strings, by insisting on flattening the strings and not trying too hard to traverse a big cons tree from generated code. Committed: http://code.google.com/p/v8/source/detail?r=3317

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M src/ia32/codegen-ia32.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Erik Corry
11 years, 1 month ago (2009-11-17 10:00:20 UTC) #1
Lasse Reichstein
11 years, 1 month ago (2009-11-17 10:08:20 UTC) #2
LGTM

http://codereview.chromium.org/402008/diff/1/4
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/402008/diff/1/4#newcode3785
Line 3785: __ CompareRoot(temp.reg(), Heap::kEmptyStringRootIndex);
Is a memory read really more efficient than an extra opcode that loads the value
as a constant?

Powered by Google App Engine
This is Rietveld 408576698