crosutils: Make running tests easier for developers

crosutils: Make running tests easier for developers

Add "fast" mode to run_remote_tests which causes the user to no longer need to emerge autotests before running them (even ones that require compilation.)

Change-Id: I60c1e8bfe562a787075b4f65b714e221e51934f7

BUG=8784
TEST=Ran bvts in and out of fast mode, ran UserCrash, SanAngeles, TPM, and backlight tests (which require compilation) in fast mode.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f010d93

[sosa, 2010-10-24 08:05:39]

mostly nits

http://codereview.chromium.org/4020004/diff/6001/7002
File run_remote_tests.sh (right):

http://codereview.chromium.org/4020004/diff/6001/7002#newcode19
run_remote_tests.sh:19: DEFINE_boolean auto_fast "${FLAGS_FALSE}" "Autodetect
fast mode"
Can you be a little more explicit here i.e. explain about workon ... you may
also just go for ${FLAGS_TRUE} and send out an email

http://codereview.chromium.org/4020004/diff/6001/7002#newcode135
run_remote_tests.sh:135: [ ${INSIDE_CHROOT} -eq 0 ] &&
our_dir="${FLAGS_chroot}/${our_dir}"
where is our_dir being set originally?  It isn't being used anywhere else

http://codereview.chromium.org/4020004/diff/6001/7002#newcode140
run_remote_tests.sh:140: echo_color "yellow" ">>> Pilfering toolchain
environment from Portage."
toolchain shell environment to be more explicit.

http://codereview.chromium.org/4020004/diff/6001/7002#newcode145
run_remote_tests.sh:145: pushd "../third_party/chromiumos-overlay/$(dirname
"${E}")" >/dev/null
Use ${SCRIPTS_DIR}../ rather than assume running from src/scripts?

http://codereview.chromium.org/4020004/diff/6001/7002#newcode188
run_remote_tests.sh:188: local
autotest="${GCLIENT_ROOT}/src/scripts/autotest_workon"
Remove ${autotest} logic ... you're deleting the file in this CL and don't use
it anymore

http://codereview.chromium.org/4020004/diff/6001/7002#newcode194
run_remote_tests.sh:194: if [ ${FLAGS_fast} -eq ${FLAGS_TRUE} ]; then
Isn't this redundant?

http://codereview.chromium.org/4020004/diff/6001/7002#newcode201
run_remote_tests.sh:201: autotest. Use installed instead by not passing
--auto_fast."
by passing --noauto_fast

http://codereview.chromium.org/4020004/diff/6001/7002#newcode205
run_remote_tests.sh:205: "Using autotests already installed in your sysroot.  To
build autotests \
Using stable autotests*

http://codereview.chromium.org/4020004/diff/6001/7002#newcode320
run_remote_tests.sh:320: # autotest needs to be.
i don't understand this either :p  it looks like it might be  direct python
variable setting

http://codereview.chromium.org/4020004/diff/6001/7002#newcode333
run_remote_tests.sh:333: sudo bash -c ". ./run_test"
is the first period necessary?

[kmixter1, 2010-10-28 22:34:19]

PTAL

http://codereview.chromium.org/4020004/diff/6001/7002
File run_remote_tests.sh (right):

http://codereview.chromium.org/4020004/diff/6001/7002#newcode19
run_remote_tests.sh:19: DEFINE_boolean auto_fast "${FLAGS_FALSE}" "Autodetect
fast mode"
On 2010/10/24 08:05:39, sosa wrote:
> Can you be a little more explicit here i.e. explain about workon ... you may
> also just go for ${FLAGS_TRUE} and send out an email

Removed this mode.  By default we're autodetecting fast mode which means this
has got to work for developers as there is no backdoor to revert behavior (other
than stop workon).

http://codereview.chromium.org/4020004/diff/6001/7002#newcode135
run_remote_tests.sh:135: [ ${INSIDE_CHROOT} -eq 0 ] &&
our_dir="${FLAGS_chroot}/${our_dir}"
On 2010/10/24 08:05:39, sosa wrote:
> where is our_dir being set originally?  It isn't being used anywhere else

Fixed - I hadn't tested this outside the chroot.

http://codereview.chromium.org/4020004/diff/6001/7002#newcode140
run_remote_tests.sh:140: echo_color "yellow" ">>> Pilfering toolchain
environment from Portage."
On 2010/10/24 08:05:39, sosa wrote:
> toolchain shell environment to be more explicit.

Done.

http://codereview.chromium.org/4020004/diff/6001/7002#newcode145
run_remote_tests.sh:145: pushd "../third_party/chromiumos-overlay/$(dirname
"${E}")" >/dev/null
On 2010/10/24 08:05:39, sosa wrote:
> Use ${SCRIPTS_DIR}../ rather than assume running from src/scripts?

Done.

http://codereview.chromium.org/4020004/diff/6001/7002#newcode188
run_remote_tests.sh:188: local
autotest="${GCLIENT_ROOT}/src/scripts/autotest_workon"
On 2010/10/24 08:05:39, sosa wrote:
> Remove ${autotest} logic ... you're deleting the file in this CL and don't use
> it anymore

Done.

http://codereview.chromium.org/4020004/diff/6001/7002#newcode194
run_remote_tests.sh:194: if [ ${FLAGS_fast} -eq ${FLAGS_TRUE} ]; then
On 2010/10/24 08:05:39, sosa wrote:
> Isn't this redundant? 

It was, fixed in rewrite.

http://codereview.chromium.org/4020004/diff/6001/7002#newcode201
run_remote_tests.sh:201: autotest. Use installed instead by not passing
--auto_fast."
On 2010/10/24 08:05:39, sosa wrote:
> by passing --noauto_fast

Correct, but I removed auto_fast.

http://codereview.chromium.org/4020004/diff/6001/7002#newcode205
run_remote_tests.sh:205: "Using autotests already installed in your sysroot.  To
build autotests \
On 2010/10/24 08:05:39, sosa wrote:
> Using stable autotests*

Done.

http://codereview.chromium.org/4020004/diff/6001/7002#newcode320
run_remote_tests.sh:320: # autotest needs to be.
On 2010/10/24 08:05:39, sosa wrote:
> i don't understand this either :p  it looks like it might be  direct python
> variable setting

It is bash shell scripting - they're using arrays.  But it was overly complex. 
I rewrote it and tested it with some networking tests that use space delimited
args.

http://codereview.chromium.org/4020004/diff/6001/7002#newcode333
run_remote_tests.sh:333: sudo bash -c ". ./run_test"
On 2010/10/24 08:05:39, sosa wrote:
> is the first period necessary?

It was because it wasn't executable.  Rewritten.