Issue 4019006: [crosutils] Remove test-image-specific change of core_pattern

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4019006: [crosutils] Remove test-image-specific change of core_pattern (Closed)

Created:
10 years, 2 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
ericli, krisr, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

[crosutils] Remove test-image-specific change of core_pattern We were snaking core dumps out from under the crash reporter on test images, and no one was even using them. We'd like to leverage the crash reporter to detect that crashes happened during a test run, so disable this. BUG=7936 TEST=spin up a VM, send SEGV to chrome. crash_reporter messages should appear in /var/log/messages Change-Id: Icc2be55616ac931ca3ec1a7810ea3e09a006a26b Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8038b8f

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	mod_for_test_scripts/002enableDumps	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ericli

10 years, 2 months ago (2010-10-22 18:27:33 UTC) #2

LGTM.

But if we could move all these changes into chromeos-test ebuild, even better.
But I understand this is out the scope of this CL.

Expand Messages | Collapse Messages