Issue 40183: Guard against a crash that can impact Dialog boxes ... this one seems to have...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40183: Guard against a crash that can impact Dialog boxes ... this one seems to have... (Closed)

Created:
11 years, 9 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
Mark Larson, sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Guard against a crash that can impact Dialog boxes ... this one seems to have already impacted Window itself, but a NULL check was already inserted in that code. http://crbug.com/4355 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11047

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/views/dialog_client_view.cc	View		1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

If we end up in this situation does it mean the user can never close ...

11 years, 9 months ago (2009-03-05 21:31:40 UTC) #2

Mark Larson

I think this change causes http://crbug.com/8448 All Close/OK buttons are broken http://codereview.chromium.org/40183/diff/1/2 File chrome/views/dialog_client_view.cc (right): ...

11 years, 9 months ago (2009-03-06 00:34:40 UTC) #4

And the kicker: we should have a test for this.

Expand Messages | Collapse Messages