Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: crash_sender

Issue 4018008: crash-reporter: Generate kernel crash signatures for server-side grouping of similar crashes (Closed) Base URL: http://git.chromium.org/git/crash-reporter.git
Patch Set: Respond to petkov review Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « crash_reporter.cc ('k') | kernel_collector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crash_sender
diff --git a/crash_sender b/crash_sender
index 9d34e34b018abe7657393266b2eef2ea030b5e7d..ebb380e805160bdc0c1d3542526467d1717dc728 100644
--- a/crash_sender
+++ b/crash_sender
@@ -201,6 +201,7 @@ send_crash() {
local hwclass="$(get_hardware_class)"
local payload_extension="${kind}"
local write_payload_size="$(get_key_value "${meta_path}" "payload_size")"
+ local sig="$(get_key_value "${meta_path}" "sig")"
[ "${kind}" = "minidump" ] && payload_extension="dmp"
local report_payload="$(get_base "${meta_path}").${payload_extension}"
local send_payload_size="$(stat --printf=%s "${report_payload}")"
@@ -214,6 +215,7 @@ send_crash() {
lecho " URL: ${url}"
lecho " Board: ${board}"
lecho " HWClass: ${hwclass}"
+ [ "${sig}" != "undefined" ] && lecho " Sig: ${sig}"
fi
lecho " Exec name: ${exec_name}"
if is_mock; then
@@ -235,6 +237,17 @@ send_crash() {
local report_id="${TMP_DIR}/report_id"
local curl_stderr="${TMP_DIR}/curl_stderr"
+ local extra_key1="write_payload_size"
+ local extra_value1="${write_payload_size}"
+ local extra_key2="send_payload_size"
+ local extra_value2="${send_payload_size}"
+ if [ "${kind}" = "kcrash" ]; then
+ extra_key1="sig"
+ extra_value1="${sig}"
+ extra_key2="sig2"
+ extra_value2="${sig}"
+ fi
+
set +e
curl "${url}" \
-F "prod=${CHROMEOS_PRODUCT}" \
@@ -243,8 +256,8 @@ send_crash() {
-F "board=${board}" \
-F "hwclass=${hwclass}" \
-F "exec_name=${exec_name}" \
- -F "write_payload_size=${write_payload_size}" \
- -F "send_payload_size=${send_payload_size}" \
+ -F "${extra_key1}=${extra_value1}" \
+ -F "${extra_key2}=${extra_value2}" \
-F "guid=<${CONSENT_ID}" -o "${report_id}" 2>"${curl_stderr}"
curl_result=$?
set -e
« no previous file with comments | « crash_reporter.cc ('k') | kernel_collector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698