Cleanup in {test_,}file_util_posix.cc

Cleanup in {test_,}file_util_posix.cc

- DCHECK_EQ instead of DCHECK(foo == bar)
- more detailed log error messages
- add a comment why we use 0777 permissions for new dirs (umask should produce sane permissions)

[Erik does not do reviews, 2009-03-05 16:40:48]

http://codereview.chromium.org/40162/diff/1/2
File base/file_util_posix.cc (right):

http://codereview.chromium.org/40162/diff/1/2#newcode160
Line 160: if (mkdir(target_path.value().c_str(), 0755) != 0) {
using 0777 is intentional since mkdir respects the user's umask.

http://codereview.chromium.org/40162/diff/1/3
File base/test_file_util_posix.cc (right):

http://codereview.chromium.org/40162/diff/1/3#newcode54
Line 54: if (mkdir(target_path.value().c_str(), 0755) != 0) {
ditto

[Paweł Hajdan Jr., 2009-03-05 21:16:00]

On 2009/03/05 16:40:48, Erik Kay wrote:
> http://codereview.chromium.org/40162/diff/1/2
> File base/file_util_posix.cc (right):
> 
> http://codereview.chromium.org/40162/diff/1/2#newcode160
> Line 160: if (mkdir(target_path.value().c_str(), 0755) != 0) {
> using 0777 is intentional since mkdir respects the user's umask.
> 
> http://codereview.chromium.org/40162/diff/1/3
> File base/test_file_util_posix.cc (right):
> 
> http://codereview.chromium.org/40162/diff/1/3#newcode54
> Line 54: if (mkdir(target_path.value().c_str(), 0755) != 0) {
> ditto

Both fixed. Added a comment.

[Erik does not do reviews, 2009-03-05 21:36:21]

LGTM