Issue 40160: Fix startup_test failures on Windows buildbot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40160: Fix startup_test failures on Windows buildbot. (Closed)

Created:
11 years, 9 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix startup_test failures on Windows buildbot. The problem seems to be an error when overwriting file which is in use (that's how EvictFileFromSystemCache works on Windows). So I used a standard workaround for such Windowsic problems and created a wrapper which retries 10 times. Similar code was there before my porting patch. TBR=agl

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
	M	chrome/test/startup/startup_test.cc	View		2 chunks	+16 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages