Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: src/heap.cc

Issue 40154: Tweak the context disposal GC heuristic: If the garbage collector ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap.cc
===================================================================
--- src/heap.cc (revision 1421)
+++ src/heap.cc (working copy)
@@ -295,11 +295,15 @@
void Heap::CollectAllGarbageIfContextDisposed() {
- if (context_disposed_pending_) {
+ // If the garbage collector interface is exposed through the global
+ // gc() function, we avoid being clever about forcing GCs when
+ // contexts are disposed and leave it to the embedder to make
+ // informed decisions about when to force a collection.
+ if (!FLAG_expose_gc && context_disposed_pending_) {
StatsRateScope scope(&Counters::gc_context);
CollectAllGarbage();
- context_disposed_pending_ = false;
}
+ context_disposed_pending_ = false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698