Use FilterContext to allow filters to access URLRequestJob data...

net/url_request/url_request_job.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_H_
 #define NET_URL_REQUEST_URL_REQUEST_JOB_H_
 
 #include <string>
 #include <vector>
 
 #include "base/ref_counted.h"
+#include "base/scoped_ptr.h"
 #include "net/base/filter.h"
 #include "net/base/load_states.h"
 
 namespace net {
 class AuthChallengeInfo;
 class HttpResponseInfo;
 class IOBuffer;
 class UploadData;
 }
 
 class GURL;
 class URLRequest;
 class URLRequestStatus;
 class URLRequestJobMetrics;
 
 // The URLRequestJob is using RefCounterThreadSafe because some sub classes
 // can be destroyed on multiple threads. This is the case of the
 // UrlRequestFileJob.
-class URLRequestJob : public base::RefCountedThreadSafe<URLRequestJob> {
+class URLRequestJob : public base::RefCountedThreadSafe<URLRequestJob>,
+                      public FilterContext {
  public:
   explicit URLRequestJob(URLRequest* request);
   virtual ~URLRequestJob();
 
   // Returns the request that owns this job. THIS POINTER MAY BE NULL if the
   // request was destroyed.
   URLRequest* request() const {
     return request_;
   }
 
@@ skipping 38 matching lines @@
   // This is just the backend for URLRequest::Read, see that function for more
   // info.
   bool Read(net::IOBuffer* buf, int buf_size, int *bytes_read);
 
   // Called to fetch the current load state for the job.
   virtual net::LoadState GetLoadState() const { return net::LOAD_STATE_IDLE; }
 
   // Called to get the upload progress in bytes.
   virtual uint64 GetUploadProgress() const { return 0; }
 
-  // Called to fetch the mime_type for this request.  Only makes sense for some
-  // types of requests. Returns true on success.  Calling this on a type that
-  // doesn't have a mime type will return false.
-  virtual bool GetMimeType(std::string* mime_type) { return false; }
-
   // Called to fetch the charset for this request.  Only makes sense for some
   // types of requests. Returns true on success.  Calling this on a type that
   // doesn't have a charset will return false.
   virtual bool GetCharset(std::string* charset) { return false; }
 
   // Called to get response info.
   virtual void GetResponseInfo(net::HttpResponseInfo* info) {}
 
   // Returns the cookie values included in the response, if applicable.
   // Returns true if applicable.
@@ skipping 81 matching lines @@
   // with a URLRequestJobMetrics object. The caller owns this object from now
   // on.
   URLRequestJobMetrics* RetrieveMetrics();
 
   // Get/Set expected content size
   int64 expected_content_size() const { return expected_content_size_; }
   void set_expected_content_size(const int64& size) {
     expected_content_size_ = size;
   }
 
+  // FilterContext methods:
+  // These methods are not applicable to all connections.
+  virtual bool GetMimeType(std::string* mime_type) const { return false; }
+  virtual bool GetURL(GURL* gurl) const;
+  virtual base::Time GetRequestTime() const;
+  virtual bool IsCachedContent() const;
+  virtual int GetInputStreambufferSize() const { return kFilterBufSize; }

[wtc, 2009/03/09 17:24:09]

Should we capitalize "buffer"?

+
  protected:
   // Notifies the job that headers have been received.
   void NotifyHeadersComplete();
 
   // Notifies the request that the job has completed a Read operation.
   void NotifyReadComplete(int bytes_read);
 
   // Notifies the request that a start error has occurred.
   void NotifyStartError(const URLRequestStatus& status);
 
@@ skipping 47 matching lines @@
   // Set the status of the job.
   void SetStatus(const URLRequestStatus& status);
 
   // Whether the job is doing performance profiling
   bool is_profiling_;
 
   // Contains IO performance measurement when profiling is enabled.
   scoped_ptr<URLRequestJobMetrics> metrics_;
 
  private:
+  // Size of filter input buffers used by this class.
+  static const int kFilterBufSize;
+
   // When data filtering is enabled, this function is used to read data
   // for the filter.  Returns true if raw data was read.  Returns false if
   // an error occurred (or we are waiting for IO to complete).
   bool ReadRawDataForFilter(int *bytes_read);
 
   // Called in response to a redirect that was not canceled to follow the
   // redirect. The current job will be replaced with a new job loading the
   // given redirect destination.
   void FollowRedirect(const GURL& location, int http_status_code);
 
@@ skipping 29 matching lines @@
   // OnResponseStarted callback and potentially redirect callbacks as well.
   bool has_handled_response_;
 
   // Expected content size
   int64 expected_content_size_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestJob);
 };
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_JOB_H_