Use FilterContext to allow filters to access URLRequestJob data...

net/base/filter.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/filter.h"
 
 #include "base/string_util.h"
 #include "net/base/gzip_filter.h"
 #include "net/base/bzip2_filter.h"
 #include "net/base/sdch_filter.h"
@@ skipping 19 matching lines @@
 const char kApplicationXGzip[]     = "application/x-gzip";
 const char kApplicationGzip[]      = "application/gzip";
 const char kApplicationXGunzip[]   = "application/x-gunzip";
 const char kApplicationXCompress[] = "application/x-compress";
 const char kApplicationCompress[]  = "application/compress";
 const char kTextHtml[]             = "text/html";
 
 }  // namespace
 
 Filter* Filter::Factory(const std::vector<FilterType>& filter_types,
-                        int buffer_size) {
-  if (filter_types.empty() || buffer_size < 0)
+                        const FilterContext& filter_context) {
+  DCHECK(filter_context.GetInputStreambufferSize() > 0);
+  if (filter_types.empty() || filter_context.GetInputStreambufferSize() <= 0)
     return NULL;
 
+
   Filter* filter_list = NULL;  // Linked list of filters.
   for (size_t i = 0; i < filter_types.size(); i++) {
-    filter_list = PrependNewFilter(filter_types[i], buffer_size, filter_list);
+    filter_list = PrependNewFilter(filter_types[i], filter_context,
+                                   filter_list);
     if (!filter_list)
       return NULL;
   }
 
+  // TODO(jar): These settings should go into the derived classes, on an as-needed basis.

[huanr, 2009/03/09 17:50:44]

Per our discussion, would be helpful to mention that the settings will be
consolidated with FilterContext.

[jar (doing other things), 2009/03/09 19:00:41]

Done.

+  std::string mime_type;
+  bool success = filter_context.GetMimeType(&mime_type);
+  DCHECK(success);
+  GURL gurl;
+  success = filter_context.GetURL(&gurl);
+  DCHECK(success);
+  base::Time request_time = filter_context.GetRequestTime();
+  bool is_cached_content = filter_context.IsCachedContent();
+
+  filter_list->SetMimeType(mime_type);
+  filter_list->SetURL(gurl);
+  // Approximate connect time with request_time. If it is not cached, then
+  // this is a good approximation for when the first bytes went on the
+  // wire.
+  filter_list->SetConnectTime(request_time, is_cached_content);
+
   return filter_list;
 }
 
 // static
 Filter::FilterType Filter::ConvertEncodingToType(
     const std::string& filter_type) {
   FilterType type_id;
   if (LowerCaseEqualsASCII(filter_type, kDeflate)) {
     type_id = FILTER_TYPE_DEFLATE;
   } else if (LowerCaseEqualsASCII(filter_type, kGZip) ||
@@ skipping 106 matching lines @@
     }
   }
 
   encoding_types->clear();
   encoding_types->push_back(FILTER_TYPE_SDCH_POSSIBLE);
   encoding_types->push_back(FILTER_TYPE_GZIP_HELPING_SDCH);
   return;
 }
 
 // static
-Filter* Filter::PrependNewFilter(FilterType type_id, int buffer_size,
+Filter* Filter::PrependNewFilter(FilterType type_id,
+                                 const FilterContext& filter_context,
                                  Filter* filter_list) {
   Filter* first_filter = NULL;  // Soon to be start of chain.
   switch (type_id) {
     case FILTER_TYPE_GZIP_HELPING_SDCH:
     case FILTER_TYPE_DEFLATE:
     case FILTER_TYPE_GZIP: {
-      scoped_ptr<GZipFilter> gz_filter(new GZipFilter());
-      if (gz_filter->InitBuffer(buffer_size)) {
+      scoped_ptr<GZipFilter> gz_filter(new GZipFilter(filter_context));
+      if (gz_filter->InitBuffer()) {
         if (gz_filter->InitDecoding(type_id)) {
           first_filter = gz_filter.release();
         }
       }
       break;
     }
     case FILTER_TYPE_BZIP2: {
-      scoped_ptr<BZip2Filter> bzip2_filter(new BZip2Filter());
-      if (bzip2_filter->InitBuffer(buffer_size)) {
+      scoped_ptr<BZip2Filter> bzip2_filter(new BZip2Filter(filter_context));
+      if (bzip2_filter->InitBuffer()) {
         if (bzip2_filter->InitDecoding(false)) {
           first_filter = bzip2_filter.release();
         }
       }
       break;
     }
     case FILTER_TYPE_SDCH:
     case FILTER_TYPE_SDCH_POSSIBLE: {
-      scoped_ptr<SdchFilter> sdch_filter(new SdchFilter());
-      if (sdch_filter->InitBuffer(buffer_size)) {
+      scoped_ptr<SdchFilter> sdch_filter(new SdchFilter(filter_context));
+      if (sdch_filter->InitBuffer()) {
         if (sdch_filter->InitDecoding(type_id)) {
           first_filter = sdch_filter.release();
         }
       }
       break;
     }
     default: {
       break;
     }
   }
 
-  if (first_filter) {
-    first_filter->next_filter_.reset(filter_list);
-  } else {
+  if (!first_filter) {
     // Cleanup and exit, since we can't construct this filter list.
     delete filter_list;
-    filter_list = NULL;
+    return NULL;
   }
+
+  first_filter->next_filter_.reset(filter_list);
   return first_filter;
 }
 
-Filter::Filter()
+Filter::Filter(const FilterContext& filter_context)
     : stream_buffer_(NULL),
       stream_buffer_size_(0),
       next_stream_data_(NULL),
       stream_data_len_(0),
       url_(),
       connect_time_(),
       was_cached_(false),
       mime_type_(),
       next_filter_(NULL),
-      last_status_(FILTER_NEED_MORE_DATA) {
+      last_status_(FILTER_NEED_MORE_DATA),
+      filter_context_(filter_context) {
 }
 
 Filter::~Filter() {}
 
-bool Filter::InitBuffer(int buffer_size) {
-  if (buffer_size < 0 || stream_buffer())
+bool Filter::InitBuffer() {
+  int buffer_size = filter_context_.GetInputStreambufferSize();
+  DCHECK(buffer_size > 0);
+  if (buffer_size <= 0 || stream_buffer())
     return false;
 
   stream_buffer_ = new net::IOBuffer(buffer_size);
 
   if (stream_buffer()) {
     stream_buffer_size_ = buffer_size;
     return true;
   }
 
   return false;
@@ skipping 68 matching lines @@
 void Filter::PushDataIntoNextFilter() {
   net::IOBuffer* next_buffer = next_filter_->stream_buffer();
   int next_size = next_filter_->stream_buffer_size();
   last_status_ = ReadFilteredData(next_buffer->data(), &next_size);
   if (FILTER_ERROR != last_status_)
     next_filter_->FlushStreamBuffer(next_size);
 }
 
 
 bool Filter::FlushStreamBuffer(int stream_data_len) {
+  DCHECK(stream_data_len <= stream_buffer_size_);
   if (stream_data_len <= 0 || stream_data_len > stream_buffer_size_)
     return false;
 
-  // bail out if there are more data in the stream buffer to be filtered.
+  DCHECK(stream_buffer());
+  // Bail out if there is more data in the stream buffer to be filtered.
   if (!stream_buffer() || stream_data_len_)
     return false;
 
   next_stream_data_ = stream_buffer()->data();
   stream_data_len_ = stream_data_len;
   return true;
 }
 
 void Filter::SetURL(const GURL& url) {
   url_ = url;
   if (next_filter_.get())
     next_filter_->SetURL(url);
 }
 
 void Filter::SetMimeType(const std::string& mime_type) {
   mime_type_ = mime_type;
   if (next_filter_.get())
     next_filter_->SetMimeType(mime_type);
 }
 
 void Filter::SetConnectTime(const base::Time& time, bool was_cached) {
   connect_time_ = time;
   was_cached_ = was_cached;
   if (next_filter_.get())
     next_filter_->SetConnectTime(time, was_cached_);
 }