Clean up HttpResponseHeaders::IsKeepAlive. Use the...

net/http/http_response_headers_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "base/basictypes.h"
 #include "base/pickle.h"
 #include "base/time.h"
 #include "net/http/http_response_headers.h"
@@ skipping 1024 matching lines @@
 
     EXPECT_EQ(tests[i].expected_len, parsed->GetContentLength());
   }
 }
 
 TEST(HttpResponseHeadersTest, IsKeepAlive) {
   const struct {
     const char* headers;
     bool expected_keep_alive;
   } tests[] = {
+    // The status line fabricated by HttpNetworkTransaction for a 0.9 response.
+    // Treated as 0.9.
+    { "HTTP/0.9 200 OK",
+      false
+    },
+    // This could come from a broken server.  Treated as 1.0 because it has a
+    // header.
+    { "HTTP/0.9 200 OK\n"
+      "connection: keep-alive\n",
+      true
+    },
     { "HTTP/1.1 200 OK\n",
       true
     },
     { "HTTP/1.0 200 OK\n",
       false
     },
     { "HTTP/1.0 200 OK\n"
       "connection: close\n",
       false
     },
@@ skipping 10 matching lines @@
       false
     },
     { "HTTP/1.1 200 OK\n"
       "connection: close\n",
       false
     },
     { "HTTP/1.1 200 OK\n"
       "connection: keep-alive\n",
       true
     },
+    { "HTTP/1.0 200 OK\n"
+      "proxy-connection: close\n",
+      false
+    },
+    { "HTTP/1.0 200 OK\n"
+      "proxy-connection: keep-alive\n",
+      true
+    },
     { "HTTP/1.1 200 OK\n"
       "proxy-connection: close\n",
       false
     },
+    { "HTTP/1.1 200 OK\n"
+      "proxy-connection: keep-alive\n",
+      true
+    },
   };
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(tests); ++i) {
     string headers(tests[i].headers);
     HeadersToRaw(&headers);
     scoped_refptr<HttpResponseHeaders> parsed =
         new HttpResponseHeaders(headers);
 
     EXPECT_EQ(tests[i].expected_keep_alive, parsed->IsKeepAlive());
   }
 }
@@ skipping 21 matching lines @@
 }
 
 TEST(HttpResponseHeadersTest, GetStatusBadStatusLine) {
   std::string headers("Foo bar.");
   HeadersToRaw(&headers);
   scoped_refptr<HttpResponseHeaders> parsed = new HttpResponseHeaders(headers);
   // The bad status line would have gotten rewritten as
   // HTTP/1.0 200 OK.
   EXPECT_EQ(std::string("OK"), parsed->GetStatusText());
 }