Ensure that we display a sad face for a windowed plugin when the plugin proce...

chrome/browser/plugin_process_host.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #include "chrome/browser/plugin_process_host.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
@@ skipping 251 matching lines @@
   }
 #else
   // TODO(port): Send the file data to the caller.
   NOTIMPLEMENTED();
 #endif
 
   // Don't access any members after this.
   delete this;
 }
 
+#if defined(OS_WIN)
 // Sends the reply to the create window message on the IO thread.
 class SendReplyTask : public Task {
  public:
-  SendReplyTask(FilePath plugin_path, IPC::Message* reply_msg)
-      : plugin_path_(plugin_path), reply_msg_(reply_msg) { }
+  SendReplyTask(FilePath plugin_path, HWND window, IPC::Message* reply_msg)
+      : plugin_path_(plugin_path),
+        reply_msg_(reply_msg),
+        window_(window){ }
 
   virtual void Run() {
     PluginProcessHost* plugin =
         PluginService::GetInstance()->FindPluginProcess(plugin_path_);
     if (!plugin)
       return;
 
+    plugin->AddWindow(window_);
     plugin->Send(reply_msg_);
   }
 
  private:
   FilePath plugin_path_;
   IPC::Message* reply_msg_;
+  HWND window_;
 };
 
-#if defined(OS_WIN)
-
 // Creates a child window of the given HWND on the UI thread.
 class CreateWindowTask : public Task {
  public:
   CreateWindowTask(
       FilePath plugin_path, HWND parent, IPC::Message* reply_msg)
       : plugin_path_(plugin_path), parent_(parent), reply_msg_(reply_msg) { }
 
   virtual void Run() {
     static ATOM window_class = 0;
     if (!window_class) {
@@ skipping 17 matching lines @@
         WS_EX_LEFT | WS_EX_LTRREADING | WS_EX_RIGHTSCROLLBAR,
         MAKEINTATOM(window_class), 0,
         WS_CHILD | WS_CLIPCHILDREN | WS_CLIPSIBLINGS,
         0, 0, 0, 0, parent_, 0, GetModuleHandle(NULL), 0);
     TRACK_HWND_CREATION(window);
 
     PluginProcessHostMsg_CreateWindow::WriteReplyParams(
         reply_msg_, window);
 
     g_browser_process->io_thread()->message_loop()->PostTask(
-        FROM_HERE, new SendReplyTask(plugin_path_, reply_msg_));
+        FROM_HERE, new SendReplyTask(plugin_path_, window, reply_msg_));
   }
 
  private:
   FilePath plugin_path_;
   HWND parent_;
   IPC::Message* reply_msg_;
 };
 
-// Destroys the given window on the UI thread.
-class DestroyWindowTask : public Task {
- public:
-  explicit DestroyWindowTask(HWND window) : window_(window) { }
-
-  virtual void Run() {
-    DestroyWindow(window_);
-    TRACK_HWND_DESTRUCTION(window_);
-  }
-
- private:
-  HWND window_;
-};
-
 void PluginProcessHost::OnCreateWindow(HWND parent,
                                        IPC::Message* reply_msg) {
   // Need to create this window on the UI thread.
   PluginService::GetInstance()->main_message_loop()->PostTask(
       FROM_HERE, new CreateWindowTask(info_.path, parent, reply_msg));
 }
 
 void PluginProcessHost::OnDestroyWindow(HWND window) {
-  PluginService::GetInstance()->main_message_loop()->PostTask(
-      FROM_HERE, new DestroyWindowTask(window));
+  std::set<HWND>::iterator window_index =
+      plugin_parent_windows_set_.find(window);
+  if (window_index != plugin_parent_windows_set_.end()) {
+    plugin_parent_windows_set_.erase(window_index);
+  }
+
+  PostMessage(window, WM_CLOSE, 0, 0);
+}
+
+void PluginProcessHost::AddWindow(HWND window) {
+  plugin_parent_windows_set_.insert(window);
 }
 
 #endif  // defined(OS_WIN)
 
 PluginProcessHost::PluginProcessHost(MessageLoop* main_message_loop)
     : ChildProcessHost(PLUGIN_PROCESS, main_message_loop),
       ALLOW_THIS_IN_INITIALIZER_LIST(resolve_proxy_msg_helper_(this, NULL)) {
 }
 
 PluginProcessHost::~PluginProcessHost() {
   // Cancel all requests for plugin processes.
   // TODO(mpcomplete): use a real process ID when http://b/issue?id=1210062 is
   // fixed.
   PluginService::GetInstance()->resource_dispatcher_host()->
       CancelRequestsForProcess(-1);
+
+#if defined(OS_WIN)
+  // We erase HWNDs from the plugin_parent_windows_set_ when we receive a
+  // notification that the window is being destroyed. If we don't receive this
+  // notification and the PluginProcessHost instance is being destroyed, it
+  // means that the plugin process crashed. We paint a sad face in this case in
+  // the renderer process. To ensure that the sad face shows up, and we don't
+  // leak HWNDs, we should destroy existing plugin parent windows.
+  std::set<HWND>::iterator window_index;
+  for (window_index = plugin_parent_windows_set_.begin();
+       window_index != plugin_parent_windows_set_.end();
+       window_index++) {
+    PostMessage(*window_index, WM_CLOSE, 0, 0);
+  }
+#endif
 }
 
 bool PluginProcessHost::Init(const WebPluginInfo& info,
                              const std::string& activex_clsid,
                              const std::wstring& locale) {
   info_ = info;
   set_name(info_.name);
 
   if (!CreateChannel())
     return false;
@@ skipping 402 matching lines @@
 }
 
 void PluginProcessHost::Shutdown() {
 #if defined(OS_WIN)
   Send(new PluginProcessMsg_BrowserShutdown);
 #else
   // TODO(port): Port plugin_messages_internal.h.
   NOTIMPLEMENTED();
 #endif
 }