Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 4011001: Convert LOG(INFO) to VLOG(1) - chrome/browser/chromeos/login/.... (Closed)

Created:
10 years, 2 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone
CC:
chromium-reviews, Paweł Hajdan Jr., nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Convert LOG(INFO) to VLOG(1) - chrome/browser/chromeos/login/. Also removes some "else" after "return". BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63409

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -149 lines) Patch
M chrome/browser/chromeos/login/account_screen_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/apply_services_customization.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/authenticator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/client_login_response_handler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/cookie_fetcher.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/eula_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/google_authenticator.cc View 1 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/html_page_screen.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/image_downloader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/issue_response_handler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
MM chrome/browser/chromeos/login/keyboard_switch_menu.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_screen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_screen_browsertest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/mock_authenticator.h View 1 2 chunks +11 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/login/online_attempt.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/owner_manager.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/ownership_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator.cc View 1 7 chunks +26 lines, -33 lines 0 comments Download
M chrome/browser/chromeos/login/registration_screen.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 16 chunks +17 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/login/update_screen.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_downloader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_accessibility_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 11 chunks +19 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Kasting
10 years, 2 months ago (2010-10-21 01:07:33 UTC) #1
Chris Masone
On 2010/10/21 01:07:33, Peter Kasting wrote: > LGTM. Will this be merged to the 552 ...
10 years, 2 months ago (2010-10-21 01:12:18 UTC) #2
Peter Kasting
10 years, 2 months ago (2010-10-21 20:40:32 UTC) #3 
On 2010/10/21 01:12:18, Chris Masone wrote:
> Will this be merged to the 552 branch?

Good question.  I don't think so.  It would be nice to not have log-spew by
default in M8, but I'd prefer not to merge changes to hundreds of files for
something that trivial :).

Powered by Google App Engine
This is Rietveld 408576698