Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 40104: Removed function SendAll from Socket (Closed)

Created:
11 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

The SendAll method on Socket was a helper method that did not really belong in platform. Committed: http://code.google.com/p/v8/source/detail?r=1414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -58 lines) Patch
M src/platform.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/platform-freebsd.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/platform-linux.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/platform-macos.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/platform-win32.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M test/cctest/test-sockets.cc View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 9 months ago (2009-03-04 09:56:41 UTC) #1
Mads Ager (chromium)
11 years, 9 months ago (2009-03-04 10:29:08 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698