Issue 40101: Check in a generated config.h file for SDCH on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40101: Check in a generated config.h file for SDCH on Linux (Closed)

Created:
11 years, 9 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai, tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Check in a generated config.h file for SDCH on Linux (as was done for mac) and add the include directory to the .gyp file. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10897

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+125 lines, -4 lines)			Patch
M	sdch/SConscript	View	2 chunks	+11 lines, -4 lines	0 comments	Download
A	sdch/linux/config.h	View	1 chunk	+113 lines, -0 lines	0 comments	Download
M	sdch/sdch.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

sgk

Also added linux/config.h to the current SCons configuration so both will build the same during ...

11 years, 9 months ago (2009-03-04 08:03:52 UTC) #1

LGTM