Changed new tab content for Guest Session.

Use special text for Guest Session instead of using standard text form Incognito mode.

BUG=chromium-os:6907
TEST=Enter Guest mode, open new tab. Check opened page.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64246

[altimofeev, 2010-10-25 16:07:58]

screenshot:
http://www.corp.google.com/~altimofeev/screenshots/guest_session1.png

[Nikita (slow), 2010-10-25 18:17:38]

http://codereview.chromium.org/4010004/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/4010004/diff/1/2#newcode7186
chrome/app/generated_resources.grd:7186: <ph name="BEGIN_LINK">&lt;a
href="$1"&gt;</ph>Learn more<ph name="END_LINK">&lt;/a&gt;</ph> about guest
mode.
Should set a proper link once it's available.

http://codereview.chromium.org/4010004/diff/1/4
File chrome/browser/dom_ui/ntp_resource_cache.cc (right):

http://codereview.chromium.org/4010004/diff/1/4#newcode202
chrome/browser/dom_ui/ntp_resource_cache.cc:202: #if defined OS_CHROMEOS
#if defined(OS_CHROMEOS)

http://codereview.chromium.org/4010004/diff/1/7
File chrome/browser/views/frame/browser_view.cc (right):

http://codereview.chromium.org/4010004/diff/1/7#newcode607
chrome/browser/views/frame/browser_view.cc:607:
should_show_off_the_record_avatar = should_show_off_the_record_avatar &&
We would perform search in switches list on each New Tab. It's logarithmic
complexity and switch list should be small enough but could we have a cached
boolean variable somewhere instead?

Please add someone who knows browser_view.cc better to the list of reviewers.

[altimofeev, 2010-10-26 08:44:52]

2Ben: please take a look at the 'browser_view.cc' part.

http://codereview.chromium.org/4010004/diff/1/4
File chrome/browser/dom_ui/ntp_resource_cache.cc (right):

http://codereview.chromium.org/4010004/diff/1/4#newcode202
chrome/browser/dom_ui/ntp_resource_cache.cc:202: #if defined OS_CHROMEOS
On 2010/10/25 18:17:38, Nikita Kostylev wrote:
> #if defined(OS_CHROMEOS)

Done.

http://codereview.chromium.org/4010004/diff/1/7
File chrome/browser/views/frame/browser_view.cc (right):

http://codereview.chromium.org/4010004/diff/1/7#newcode607
chrome/browser/views/frame/browser_view.cc:607:
should_show_off_the_record_avatar = should_show_off_the_record_avatar &&
On 2010/10/25 18:17:38, Nikita Kostylev wrote:
> We would perform search in switches list on each New Tab. It's logarithmic
> complexity and switch list should be small enough but could we have a cached
> boolean variable somewhere instead?
> 
> Please add someone who knows browser_view.cc better to the list of reviewers.

Actually, this method is called when browser frame is being drawn, not a tab. So
it is really called often. At the same time there is a couple of things which
are more resource-intensive (for example drawing itself). From my point of view
local cached values pollute the code and makes it less consistent. The good
solution to deal with this efficiency issue would be adding IsGuestSession flag
to the current profile (the way it is done with IsOffTheRecord). But this change
should be done in separate CL.

[Nikita (slow), 2010-10-27 12:47:01]

I'd say it safe to submit this CL as is and add guest_mode_ bool member for
Profile in a separate CL.

[Ben Goodger (Google), 2010-10-28 18:30:04]

I haven't reviewed this yet so please revert it immediately.

I don't like the idea of overloading the incognito man with "guest". They have
subtly different semantics.

Also, we need to come up with a more scalable way of handling ChromeOS' UI
modifications than continually adding OS_CHROMEOS ifdefs everywhere. It makes a
mess.

[altimofeev, 2010-10-29 07:41:02]

On 2010/10/28 18:30:04, Ben Goodger wrote:
> I haven't reviewed this yet so please revert it immediately.
> 
> I don't like the idea of overloading the incognito man with "guest". They have
> subtly different semantics.
> 
> Also, we need to come up with a more scalable way of handling ChromeOS' UI
> modifications than continually adding OS_CHROMEOS ifdefs everywhere. It makes
a
> mess.

Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=64374

[altimofeev, 2010-10-29 10:38:20]

I have started another issue: http://codereview.chromium.org/4186009/show