Issue 40095: Enable interstitial pages for SSL certificate errors on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40095: Enable interstitial pages for SSL certificate errors on Linux. (Closed)

Created:
11 years, 9 months ago by Markus (顧孟勤)

Modified:
9 years, 7 months ago

Reviewers:
jcampan, Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enable interstitial pages for SSL certificate errors on Linux. There are still problems with this patch, as acknowledging the interstitial page often fails to load a new page. Instead, it just displays a blank gray page. This appears to be somewhat timing related. Nonetheless, this changelist is strictly an improvement over what we have right now. So, I would still like to commit it. Ideally, I'd like to remove the special-case Windows code. But I don't have a Windows machine to check whether the new code is actually a full superset of the old Windows code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11177

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -15 lines)			Patch
	M	chrome/browser/ssl/ssl_blocking_page.cc	View	1	3 chunks	+0 lines, -5 lines	0 comments	Download
	M	chrome/browser/tab_contents/interstitial_page.cc	View	1	5 chunks	+18 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

This doesn't look bad to me, but I don't know the code too well. Jay, ...

11 years, 9 months ago (2009-03-06 23:33:40 UTC) #2

Evan Martin

I will say LGTM and Jay can comment if he wants to later. :)

11 years, 9 months ago (2009-03-06 23:34:39 UTC) #3

jcampan

11 years, 9 months ago (2009-03-06 23:48:59 UTC) #4

LGTM
This probably should work on Windows.
Once you have checked-in I'll look into it.

Expand Messages | Collapse Messages