Changes spellcheck_unittest to read dictionaries directly from the src tree

Changes spellcheck_unittest to read dictionaries directly from the src tree.  Removes the build rules to copy test dictionaries to Dictionaries/.

[rohitrao (Google), 2009-03-04 01:28:12]

I've tested this by clobbering and rebuilding on all three platforms.  The
Dictionaries directory is no longer created by the build, and unit_tests passes
without it.

I've never made a .vcproj change before, so if someone wants to look at that
extra-carefully, I wouldn't mind.

[sidchat (Google), 2009-03-04 01:42:27]

Changes to file spellcheck_unittest.cc looks good 2 me.

-Sid

On 2009/03/04 01:28:12, rohitrao wrote:
> I've tested this by clobbering and rebuilding on all three platforms.  The
> Dictionaries directory is no longer created by the build, and unit_tests
passes
> without it.
> 
> I've never made a .vcproj change before, so if someone wants to look at that
> extra-carefully, I wouldn't mind.

[Scott Hess - ex-Googler, 2009-03-04 19:38:49]

lgtm

http://codereview.chromium.org/40082/diff/1002/18
File chrome/third_party/hunspell/hunspell.vcproj (left):

http://codereview.chromium.org/40082/diff/1002/18#oldcode19
Line 19: </ToolFiles>
Should copy_dictionary_files.rules be removed from svn, too?

[rohitrao (Google), 2009-03-04 19:59:11]

Thanks for the reviews!

shess:  Do you have commit privileges?  Can you help land this patch?

http://codereview.chromium.org/40082/diff/1002/18
File chrome/third_party/hunspell/hunspell.vcproj (left):

http://codereview.chromium.org/40082/diff/1002/18#oldcode19
Line 19: </ToolFiles>
On 2009/03/04 19:38:49, shess wrote:
> Should copy_dictionary_files.rules be removed from svn, too?

Good catch.  No one should be referencing this file anymore, so deleting it
should be ok, but I'm running a Windows build to double-check.

[Mark Mentovai, 2009-03-04 20:07:28]

LGTM, thanks!

[Scott Hess - ex-Googler, 2009-03-04 23:23:14]

Indeed I do have commit, and since I haven't landed a patch, it would be good to
figure that out.  I'll go off and research for a couple minutes, here...

On 2009/03/04 19:59:11, rohitrao wrote:
> Thanks for the reviews!
> 
> shess:  Do you have commit privileges?  Can you help land this patch?
> 
> http://codereview.chromium.org/40082/diff/1002/18
> File chrome/third_party/hunspell/hunspell.vcproj (left):
> 
> http://codereview.chromium.org/40082/diff/1002/18#oldcode19
> Line 19: </ToolFiles>
> On 2009/03/04 19:38:49, shess wrote:
> > Should copy_dictionary_files.rules be removed from svn, too?
> 
> Good catch.  No one should be referencing this file anymore, so deleting it
> should be ok, but I'm running a Windows build to double-check.

[Scott Hess - ex-Googler, 2009-03-05 01:37:30]

On 2009/03/04 23:23:14, shess wrote:
> Indeed I do have commit, and since I haven't landed a patch, it would be good
to
> figure that out.  I'll go off and research for a couple minutes, here...
> 
> On 2009/03/04 19:59:11, rohitrao wrote:
> > Thanks for the reviews!
> > 
> > shess:  Do you have commit privileges?  Can you help land this patch?
> > 
> > http://codereview.chromium.org/40082/diff/1002/18
> > File chrome/third_party/hunspell/hunspell.vcproj (left):
> > 
> > http://codereview.chromium.org/40082/diff/1002/18#oldcode19
> > Line 19: </ToolFiles>
> > On 2009/03/04 19:38:49, shess wrote:
> > > Should copy_dictionary_files.rules be removed from svn, too?
> > 
> > Good catch.  No one should be referencing this file anymore, so deleting it
> > should be ok, but I'm running a Windows build to double-check.

http://src.chromium.org/viewvc/chrome?view=rev&revision=10951

I committed this via git-cl, and cannot for the life of me determine if it
should have closed the issue automatically or not...