Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issue 4007005: Change preflight cleanup process to always be run before any run. (Closed)

Created:
10 years, 2 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
scottz
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Change preflight cleanup process to always be run before any run and add lazy unmount before every run. Change-Id: If7db175f828fccdd4caa342a0370e842503f16dc BUG=8015 TEST=Ran it with cbuildbot with/without --clobber with/without old state. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=dcd1de0

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -27 lines) Patch
M bin/cbuildbot.py View 8 chunks +35 lines, -27 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
sosa
10 years, 2 months ago (2010-10-21 23:30:44 UTC) #1
scottz
LGTM, if you don't want to redo the pipe into stdin of your output that ...
10 years, 2 months ago (2010-10-22 00:07:31 UTC) #2
sosa
Sadly RunCommand doesn't support piping within a command (at least I couldn't get it to ...
10 years, 2 months ago (2010-10-22 00:34:34 UTC) #3
scottz
10 years, 2 months ago (2010-10-22 00:39:10 UTC) #4
Grr that is the other RunCommand. We need to start just porting those features
into this lib otherwise we will never use them.

LGTM

Powered by Google App Engine
This is Rietveld 408576698