Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8698)

Unified Diff: chrome/chrome.gyp

Issue 40066: Branding of Chrome.app.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/app-Info.plist ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
===================================================================
--- chrome/chrome.gyp (revision 10904)
+++ chrome/chrome.gyp (working copy)
@@ -1328,7 +1328,6 @@
'app/nibs/en.lproj/BrowserWindow.xib',
'app/nibs/en.lproj/MainMenu.xib',
'app/nibs/en.lproj/TabContents.xib',
- 'app/theme/chromium/chromium.icns',
'app/theme/back.pdf',
'app/theme/forward.pdf',
'app/theme/go.pdf',
@@ -1352,7 +1351,16 @@
},
'conditions': [
['OS=="mac"', {
- 'product_name': 'Chromium',
+ # 'branding' is a variable defined in common.gypi
+ # (e.g. "Chromium", "Chrome")
+ 'product_name': '<(branding)',
+ 'conditions': [
+ ['branding=="Chrome"', {
+ 'mac_bundle_resources': ['app/theme/google_chrome/chrome.icns'],
+ }, { # else: branding!="Chrome"
+ 'mac_bundle_resources': ['app/theme/chromium/chromium.icns'],
+ }],
+ ],
}],
['OS!="win"', {
'variables': {
@@ -1746,4 +1754,30 @@
],
},
],
+ # On Mac only, add a project target called "package_app" that only
+ # runs a shell script (package_chrome.sh).
+ 'conditions': [
+ ['OS=="mac"',
+ { 'targets': [
+ {
+ 'target_name': 'package_app',
+ # do NOT place this in the 'all' list; most won't want it.
+ # In gyp, booleans are 0/1 not True/False.
+ 'suppress_wildcard': 1,
+ 'type': 'none',
+ 'dependencies': [
+ 'app',
+ ],
+ 'actions': [
+ {
+ 'inputs': [],
+ 'outputs': [],
+ 'action_name': 'package_chrome',
+ 'action': ['tools/mac/package_chrome.sh' ],
+ },
+ ], # 'actions'
+ },
+ ]}, # 'targets'
+ ], # OS=="mac"
+ ], # 'conditions'
}
« no previous file with comments | « chrome/app/app-Info.plist ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698