Adding append to make_factory_package

Adding append to make_factory_package

Change-Id: I37f0c93d1285c27731b58a977b91aa85f4fb2e63

BUG=7115
TEST=

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d07981d

[Hung-Te, 2010-10-22 09:18:12]

http://codereview.chromium.org/4006003/diff/1/2
File make_factory_package.sh (right):

http://codereview.chromium.org/4006003/diff/1/2#newcode59
make_factory_package.sh:59: if [ ! -z "${FLAGS_subfolder}" ] ; then
"! -z" should be replaced by "-n"

http://codereview.chromium.org/4006003/diff/1/2#newcode74
make_factory_package.sh:74: 
looks like no need of the blank line here

http://codereview.chromium.org/4006003/diff/1/2#newcode163
make_factory_package.sh:163: if [ ! -z "${FLAGS_subfolder}" ] && \
No need the trailing \ . The && implies line concatenation.

"! -z" should be replaced by "-n".

http://codereview.chromium.org/4006003/diff/1/2#newcode164
make_factory_package.sh:164: [ -f ${OMAHA_DIR}"/miniomaha.conf" ] ; then
Please include the variable in quote, like
 -f "${OMAHA_DIR}/miniomaha.conf"

http://codereview.chromium.org/4006003/diff/1/2#newcode166
make_factory_package.sh:166: mv ${OMAHA_DIR}/miniomaha_tmp.conf
${OMAHA_DIR}/miniomaha.conf
The sed + mv can be changed to
 sed -i '$d' "${OMAHA_DIR}/miniomaha.conf"

http://codereview.chromium.org/4006003/diff/1/2#newcode167
make_factory_package.sh:167: subfolder=${FLAGS_subfolder}"/"
I'd prefer to write this as subfolder="${FLAGS_subfolder}/"

http://codereview.chromium.org/4006003/diff/1/2#newcode169
make_factory_package.sh:169: echo -e "config = [\n" >
${OMAHA_DIR}/miniomaha.conf
This will create one more extra line.
I think 'echo "config = [" > ' is enough.

[Nick Sanders, 2010-10-22 18:06:08]

lgtm w/ Hungte's style changes and more commenting.

http://codereview.chromium.org/4006003/diff/1/2
File make_factory_package.sh (right):

http://codereview.chromium.org/4006003/diff/1/2#newcode31
make_factory_package.sh:31: DEFINE_string subfolder "" \
Can you add a comment somewhere in the file that mentions that you can only add
new subfolders, since the old configs will remain, and they must have different
board-ids.

http://codereview.chromium.org/4006003/diff/1/2#newcode165
make_factory_package.sh:165: sed '$d' < ${OMAHA_DIR}/miniomaha.conf >
${OMAHA_DIR}/miniomaha_tmp.conf
Can you also comment that this is deleting the last line, which is the closing
curly brace in the config.

http://codereview.chromium.org/4006003/diff/1/2#newcode174
make_factory_package.sh:174: 'factory_image': '"$subfolder"rootfs-test.gz',
Can you add curly braces around ${subfolder}