Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 4005002: Add ability to blacklist packages from chromeos-base/chromeos. (Closed)

Created:
10 years, 2 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Add ability to blacklist packages from chromeos-base/chromeos. Change-Id: I05370137dbe9f9adc7b18f2ff77d1b7680275c37 BUG=7973 TEST=Ran with/without current blacklist file. Also, added chromeos-base/chromeos-chrome to test it actually dies correctly. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e38f90f

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use petkov sug #

Patch Set 3 : Remove extra lines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M build_image View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A chromeos_blacklist View 1 chunk +3 lines, -0 lines 0 comments Download
M get_package_list View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sosa
Base blacklist includes java & python
10 years, 2 months ago (2010-10-20 22:24:51 UTC) #1
petkov
LGTM w/ a couple of optional suggestions. Thanks! http://codereview.chromium.org/4005002/diff/1/2 File build_image (right): http://codereview.chromium.org/4005002/diff/1/2#newcode109 build_image:109: local ...
10 years, 2 months ago (2010-10-20 22:36:53 UTC) #2
sosa
10 years, 2 months ago (2010-10-20 23:07:15 UTC) #3
Done and pushed.

On Wed, Oct 20, 2010 at 3:36 PM,  <petkov@chromium.org> wrote:
> LGTM w/ a couple of optional suggestions. Thanks!
>
>
>
> http://codereview.chromium.org/4005002/diff/1/2
> File build_image (right):
>
> http://codereview.chromium.org/4005002/diff/1/2#newcode109
> build_image:109: local package_list=$(${SCRIPTS_DIR}/get_package_list \
> have you tried/considered something like:
>
> get_package_list | grep -x -f ${package_blacklist_file}
>
> not sure if it works :)
>
> http://codereview.chromium.org/4005002/diff/1/2#newcode112
> build_image:112: if echo "${package_list}" | egrep ^${package}$ 2>1 >
> /dev/null; then
> you can do grep -x ${package} here, I think.
>
> http://codereview.chromium.org/4005002/show
>

Powered by Google App Engine
This is Rietveld 408576698