Issue 40023: Streamline CodeGenerator::Comparison in the IA32 code generator. When...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40023: Streamline CodeGenerator::Comparison in the IA32 code generator. When... (Closed)

Created:
11 years, 9 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Streamline CodeGenerator::Comparison in the IA32 code generator. When doing constant folding, handle only the cases that actually arise. This avoids some complicated logic, some extra comparisons, and fixes issue 247: http://code.google.com/p/v8/issues/detail?id=247 Committed: http://code.google.com/p/v8/source/detail?r=1410

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -13 lines)			Patch
	M	src/codegen-ia32.cc	View	1	3 chunks	+16 lines, -13 lines	0 comments	Download

Total messages: 2 (0 generated)

Kevin Millikin (Chromium)

We should really make CodeGenerator::Comparison take a Token::Value instead of a Condition---there is no reason ...

11 years, 9 months ago (2009-03-03 17:59:24 UTC) #1

LGTM.