Add remote debugging front end to developer shell....

Add remote debugging front end to developer shell.

D8 now supports demote debuggign of a V8 instance with the debugger agent enabled. Running D8 with the option --remote-debugger will try to connect to a V8 debugger agent and process the debugging protocol. The command line UI is the same as for the D8 in-process debugger as the same code is used for processing the debugger JSON. 

Committed: http://code.google.com/p/v8/source/detail?r=1411

[Mads Ager (chromium), 2009-03-04 08:08:10]

LGTM

http://codereview.chromium.org/40011/diff/1/3
File src/d8-debug.cc (right):

http://codereview.chromium.org/40011/diff/1/3#newcode270
Line 270: String::Utf8Value str(details->Get(String::New("text")));
Will this always succeed?  If it can potentially fail, you should make sure to
guard 'printf("%s\n", *str)' with a null check on str.  (GCC optimizes
printf("%s\n", ...) to puts(...) which cannot handle being passed a null
pointer).

http://codereview.chromium.org/40011/diff/1/3#newcode288
Line 288: Shell::ReportException(&try_catch);
Indentation.

http://codereview.chromium.org/40011/diff/1/5
File src/d8-debug.h (right):

http://codereview.chromium.org/40011/diff/1/5#newcode85
Line 85: // Linked list of events from debugged V8 and form keyboard input.
Access to
form -> from

http://codereview.chromium.org/40011/diff/1/5#newcode100
Line 100: explicit ReceiverThread(RemoteDebugger* remote_debugger) :
I think we normally put the ':' on the next line and use a four-space indent?

[Søren Thygesen Gjesse, 2009-03-04 09:27:37]

http://codereview.chromium.org/40011/diff/1/3
File src/d8-debug.cc (right):

http://codereview.chromium.org/40011/diff/1/3#newcode270
Line 270: String::Utf8Value str(details->Get(String::New("text")));
On 2009/03/04 08:08:10, Mads Ager wrote:
> Will this always succeed?  If it can potentially fail, you should make sure to
> guard 'printf("%s\n", *str)' with a null check on str.  (GCC optimizes
> printf("%s\n", ...) to puts(...) which cannot handle being passed a null
> pointer).

*str can be NULL if details->Get(String::New("text")) IsEmpty, or its ToString
value IsEmpty. Added a NULL pointer check to not rely on printf handling it.

http://codereview.chromium.org/40011/diff/1/3#newcode288
Line 288: Shell::ReportException(&try_catch);
On 2009/03/04 08:08:10, Mads Ager wrote:
> Indentation.

Done.

http://codereview.chromium.org/40011/diff/1/5
File src/d8-debug.h (right):

http://codereview.chromium.org/40011/diff/1/5#newcode85
Line 85: // Linked list of events from debugged V8 and form keyboard input.
Access to
On 2009/03/04 08:08:10, Mads Ager wrote:
> form -> from

Done.

http://codereview.chromium.org/40011/diff/1/5#newcode100
Line 100: explicit ReceiverThread(RemoteDebugger* remote_debugger) :
On 2009/03/04 08:08:10, Mads Ager wrote:
> I think we normally put the ':' on the next line and use a four-space indent?

Done.