Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 4001006: Implement boot device r/w functions for vboot (Closed)

Created:
10 years, 2 months ago by Che-Liang Chiou
Modified:
9 years ago
CC:
chromium-os-reviews_chromium.org, dneiss, Olof Johansson, robotboy, chromeboy, amoljadi
Visibility:
Public.

Description

Implement boot device r/w functions for vboot BUG=None TEST=Manual Test procedure: 1. Compile with VBOOT_DEBUG flag on successfully 2. Run u-boot on dev board as follows: (Assume you have mmc device on dev board) CrOS> mmc init CrOS> cros bootdev set mmc 1 CrOS> cros bootdev (info of mmc1) CrOS> read mmc 1 0x20000000 1 2 CrOS> md.b 0x20000000 (mmc1 content) CrOS> cros bootdev read 0x20001000 1 2 CrOS> md.b 0x20001000 (mmc1 content) CrOS> cmp.b 0x20000000 0x20001000 0x400 (compare the blocks, should be identical) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=edbc535

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -0 lines) Patch
M Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M common/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
A common/cmd_cros.c View 1 chunk +168 lines, -0 lines 0 comments Download
M config.mk View 1 chunk +3 lines, -0 lines 0 comments Download
M include/config_cmd_all.h View 1 chunk +1 line, -0 lines 2 comments Download
M include/configs/chromeos/common.h View 1 chunk +10 lines, -0 lines 0 comments Download
A lib_generic/chromeos/Makefile View 1 chunk +55 lines, -0 lines 0 comments Download
A lib_generic/chromeos/boot_device.c View 1 chunk +119 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Che-Liang Chiou
10 years, 2 months ago (2010-10-24 11:44:34 UTC) #1
robotboy
LGTM, with the one change below. http://codereview.chromium.org/4001006/diff/1/6 File include/config_cmd_all.h (right): http://codereview.chromium.org/4001006/diff/1/6#newcode26 include/config_cmd_all.h:26: #define CONFIG_CMD_CROS /* ...
10 years, 1 month ago (2010-10-25 16:40:48 UTC) #2
Che-Liang Chiou
http://codereview.chromium.org/4001006/diff/1/6 File include/config_cmd_all.h (right): http://codereview.chromium.org/4001006/diff/1/6#newcode26 include/config_cmd_all.h:26: #define CONFIG_CMD_CROS /* Chrome OS verify boot support*/ On ...
10 years, 1 month ago (2010-10-26 00:39:34 UTC) #3
Randall Spangler
10 years, 1 month ago (2010-10-26 20:27:46 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698