Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: src/codegen-ia32.cc

Issue 40007: Disable the compilation caching for scripts to make it... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compilation-cache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codegen-ia32.cc
===================================================================
--- src/codegen-ia32.cc (revision 1404)
+++ src/codegen-ia32.cc (working copy)
@@ -154,18 +154,14 @@
// Get outer context and create a new context based on it.
frame_->PushFunction();
Result context = frame_->CallRuntime(Runtime::kNewContext, 1);
+
// Update context local.
frame_->SaveContextRegister();
- if (kDebug) {
- JumpTarget verified_true(this);
- // Verify eax and esi are the same in debug mode
+ // Verify that the runtime call result and esi agree.
+ if (FLAG_debug_code) {
__ cmp(context.reg(), Operand(esi));
- context.Unuse();
- verified_true.Branch(equal);
- frame_->SpillAll();
- __ int3();
- verified_true.Bind();
+ __ Assert(equal, "Runtime::NewContext should end up in esi");
}
}
@@ -1870,16 +1866,10 @@
// Update context local.
frame_->SaveContextRegister();
- if (kDebug) {
- JumpTarget verified_true(this);
- // Verify that the result of the runtime call and the esi register are
- // the same in debug mode.
+ // Verify that the runtime call result and esi agree.
+ if (FLAG_debug_code) {
__ cmp(context.reg(), Operand(esi));
- context.Unuse();
- verified_true.Branch(equal);
- frame_->SpillAll();
- __ int3();
- verified_true.Bind();
+ __ Assert(equal, "Runtime::NewContext should end up in esi");
}
}
« no previous file with comments | « no previous file | src/compilation-cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698