Issue 400029: Linux: update install-build-deps.sh to build gold from binutils 2.20....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 400029: Linux: update install-build-deps.sh to build gold from binutils 2.20.... (Closed)

Created:
11 years, 1 month ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux: update install-build-deps.sh to build gold from binutils 2.20. BUG=none TEST=builds gold that supports --gc-sections. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32315

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -77 lines)			Patch
	M	build/install-build-deps.sh	View		1 chunk	+35 lines, -77 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years, 1 month ago (2009-11-18 02:42:23 UTC) #2

LGTM

http://codereview.chromium.org/400029/diff/1/2
File build/install-build-deps.sh (right):

http://codereview.chromium.org/400029/diff/1/2#newcode67
Line 67: +				 "from 0x%"PRIx64" to 0x%"PRIx64),
Can you upstream this patch?

http://sourceware.org/bugzilla/show_bug.cgi?id=10949

Expand Messages | Collapse Messages