Issue 4000005: autotest: Test new kernel signature generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4000005: autotest: Test new kernel signature generation (Closed)

Created:
10 years, 2 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

autotest: Test new kernel signature generation BUG=5868 TEST=Ran these tests Change-Id: I026d3f74b73ae5d437ba4f1fbdfffe600fa497c0 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d79140e

Patch Set 1 #

Patch Set 2 : bug fixes #

Total comments: 1

Patch Set 3 : Respond to review comments #

Patch Set 4 : no really... #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -3 lines)			Patch
M	client/bin/site_crash_test.py	View		3 chunks	+7 lines, -0 lines	0 comments	Download
M	client/site_tests/logging_KernelCrash/logging_KernelCrash.py	View	1 2	2 chunks	+25 lines, -3 lines	0 comments	Download
M	client/site_tests/logging_UserCrash/logging_UserCrash.py	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 2 months ago (2010-10-22 18:46:43 UTC) #2

LGTM

http://codereview.chromium.org/4000005/diff/3001/4003
File client/site_tests/logging_UserCrash/logging_UserCrash.py (right):

http://codereview.chromium.org/4000005/diff/3001/4003#newcode249
client/site_tests/logging_UserCrash/logging_UserCrash.py:249: raise
error.TestFail('User crash should have not have signature')
should not have

Expand Messages | Collapse Messages