Issue 3997001: common.sh: switch out echo -ne for printf and fix incorrect offset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3997001: common.sh: switch out echo -ne for printf and fix incorrect offset (Closed)

Created:
10 years, 2 months ago by Will Drewry

Modified:
9 years, 7 months ago

Reviewers:
Nick Sanders, adlr

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

common.sh: switch out echo -ne for printf and fix incorrect offset echo -ne isn't portable but printf with octals is so this makes the switch. In addition, the current offset is off by 3 and is updating the UUID space. This was from style cleanup and all functional test passed - of course. This change fixes that too. TEST=built and installed and checked ro enforcement works BUG=chromium-os:7972 Change-Id: Ifb3cb2c6f3219af819baff5750453439e1ba6edf

Patch Set 1 #

Patch Set 2 : ugh and fix a last minute bug! #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	common.sh	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Will Drewry

Realized I introduced a last minute bug when I shuffled around the prior change. Doesn't ...

10 years, 2 months ago (2010-10-20 22:38:54 UTC) #2

LGTM

Expand Messages | Collapse Messages