Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 3992001: AU: Really disable URL/version setting over D-Bus on official images. (Closed)

Created:
10 years, 2 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, petkov, adlr
Visibility:
Public.

Description

AU: Really disable URL/version setting over D-Bus on official images. BUG=7159 TEST=unit tests, tested on production image too... Change-Id: I82560023a1a231732f56ccfbd8c4837ae713f696 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ba3fb17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M dbus_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
petkov
PTAL... There was a latent bug in the pre-existing code that it didn't really used ...
10 years, 2 months ago (2010-10-20 21:33:11 UTC) #1
adlr
10 years, 2 months ago (2010-10-20 21:34:22 UTC) #2
LGTM

On Wed, Oct 20, 2010 at 2:33 PM, <petkov@chromium.org> wrote:

> Reviewers: adlr,
>
> Message:
> PTAL... There was a latent bug in the pre-existing code that it didn't
> really
> used the new url/version values.
>
>
> Description:
> AU: Really disable URL/version setting over D-Bus on official images.
>
> BUG=7159
> TEST=unit tests, tested on production image too...
>
> Change-Id: I82560023a1a231732f56ccfbd8c4837ae713f696
>
> Please review this at http://codereview.chromium.org/3992001/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/update_engine.git
>
> Affected files:
>  M dbus_service.cc
>
>
> Index: dbus_service.cc
> diff --git a/dbus_service.cc b/dbus_service.cc
> index
>
63fbf501da1f2c841d4166e63c3211ef782be261..08b953dd5f7a831e61d7a3c6157e0226475949f1
> 100644
> --- a/dbus_service.cc
> +++ b/dbus_service.cc
> @@ -69,7 +69,7 @@ gboolean
> update_engine_service_attempt_update(UpdateEngineService* self,
>   }
>   LOG(INFO) << "Attempt update: app_version=\"" << update_app_version <<
> "\" "
>             << "omaha_url=\"" << update_omaha_url << "\"";
> -  self->update_attempter_->CheckForUpdate(app_version, omaha_url);
> +  self->update_attempter_->CheckForUpdate(update_app_version,
> update_omaha_url);
>   return TRUE;
>  }
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698