Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 399111: Implement IS_OBJECT and IS_FUNCTION as inlined runtime functions.... (Closed)

Created:
11 years, 1 month ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implement IS_OBJECT and IS_FUNCTION as inlined runtime functions. Summary: This change fixes a performance regression introduced by the special handling of regular expressions in typeof expressions. As a result we regain ~8% speedup on 3d-raytrace and ~13% on boyer (vs bleeding edge) Description: The macros IS_OBJECT and IS_FUNCTION are frequently used in the JS runtime functions. By introducing new inlined runtime functions %_IsFunction and %_IsObject we avoid invoking the more expensive %_ClassOf function plus comparing its result to a string. Committed: http://code.google.com/p/v8/source/detail?r=3335

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -4 lines) Patch
M src/arm/codegen-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 1 chunk +45 lines, -0 lines 0 comments Download
M src/codegen.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 1 chunk +49 lines, -0 lines 0 comments Download
M src/macros.py View 1 chunk +2 lines, -3 lines 0 comments Download
M src/x64/codegen-x64.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
11 years, 1 month ago (2009-11-19 06:57:04 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/399111/diff/1/8 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/399111/diff/1/8#newcode3404 Line 3404: // It can be an undetectable object. ...
11 years, 1 month ago (2009-11-19 07:16:48 UTC) #2
fschneider
11 years, 1 month ago (2009-11-19 07:35:51 UTC) #3
http://codereview.chromium.org/399111/diff/1/8
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/399111/diff/1/8#newcode3404
Line 3404: // It can be an undetectable object.
On 2009/11/19 07:16:48, Mads Ager wrote:
> Maybe explicitly mention that undetectable objects have to act as undefined in
> typeof tests?

Done.

Powered by Google App Engine
This is Rietveld 408576698