Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 399089: Remove invuca.icu table from the ICU data file. Cutting down the data size by... (Closed)

Created:
11 years, 1 month ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove invuca.icu table from the ICU data file again. It was added to make Chrome not crash with a webkit patch for bug 30437 (https://bugs.webkit.org/show_bug.cgi?id=30437) However, the webkit patch was rolled back so that we don't need invuca.icu for now. Removing it will cut down the data size by 230k (before compression and in the Chrome executable on Linux/Mac and the ICU data dll on Linux). This has to be added back when it becomes necessary again to fix the aforementioned webkit bug. See also http://crbug.com/28132 (a bug about ~ 4kB of space wasted by copyright statements) BUG=20406 TEST=NONE http://src.chromium.org/viewvc/chrome?view=rev&revision=32640

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -27 lines) Patch
M third_party/icu/patches/data.build.patch View 6 chunks +11 lines, -27 lines 0 comments Download
M third_party/icu/patches/segmentation.patch.txt View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jungshik at Google
11 years, 1 month ago (2009-11-20 18:27:17 UTC) #1
Evan Martin
Do we expect the bug to be fixed again soon? Is it worth cutting this ...
11 years, 1 month ago (2009-11-20 18:50:01 UTC) #2
jungshik at Google
On 2009/11/20 18:50:01, Evan Martin wrote: > Do we expect the bug to be fixed ...
11 years, 1 month ago (2009-11-20 19:00:52 UTC) #3
Evan Martin
11 years, 1 month ago (2009-11-20 19:07:14 UTC) #4
LGTM rubber stamp (I don't understand the build files, but the intent of change
sounds good)

Powered by Google App Engine
This is Rietveld 408576698