Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3304)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 399077: test_shell buildable on ARM (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/interactive_ui/interactive_ui_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 6a703abdd04f7789bdd1f135616786a90f228e75..2cd25b1245866d5fa0c7b0c71fd897491f6fe9c5 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -718,8 +718,8 @@
# flag.
'cflags!': [ '-fvisibility=hidden' ],
'conditions': [
- ['target_arch=="x64"', {
- # Shared libraries need -fPIC on x86-64
+ ['target_arch=="x64" or target_arch=="arm"', {
+ # Shared libraries need -fPIC on x86-64 and arm
'cflags': ['-fPIC']
}]
],
« no previous file with comments | « no previous file | chrome/test/interactive_ui/interactive_ui_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698