Issue 399070: Add scm.*.GetEmail() to retrieve the user email. Use this email for try job emails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 399070: Add scm.*.GetEmail() to retrieve the user email. Use this email for try job emails. (Closed)

Created:
11 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Mandeep Singh Baines

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add scm.*.GetEmail() to retrieve the user email. Use this email for try job emails. TEST=not much BUG=none

Patch Set 2 : Use CaptureInfo() #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -11 lines)			Patch
M	scm.py	View	1	2 chunks	+61 lines, -0 lines	0 comments	Download
M	tests/gclient_scm_test.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	tests/scm_unittest.py	View		3 chunks	+11 lines, -3 lines	0 comments	Download
M	tests/trychange_unittest.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	trychange.py	View		3 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mandeep Singh Baines

http://codereview.chromium.org/399070/diff/1/2 File scm.py (right): http://codereview.chromium.org/399070/diff/1/2#newcode455 Line 455: def ReadEntries(filename): Why can't you use SVN::CaptureInfo for ...

11 years, 1 month ago (2009-11-20 06:01:43 UTC) #2

M-A Ruel

On 2009/11/20 06:01:43, msb wrote: > Why can't you use SVN::CaptureInfo for this? That was ...

11 years, 1 month ago (2009-11-20 19:06:27 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 399070: Add scm.*.GetEmail() to retrieve the user email. Use this email for try job emails. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Use CaptureInfo() #

Messages