Issue 399068: Move base64 from 'net/base' into 'base'.

Issue 399068: Move base64 from 'net/base' into 'base'. (Closed)

Created:
11 years, 1 month ago by hayato

Modified:
9 years, 7 months ago

Reviewers:
wtc, rafaelw

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Move base64 from 'net/base' into 'base'. BUG=13572 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32918

Patch Set 4 : rebase #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -58 lines)			Patch
M	base/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	base/base.gyp	View	1 2 3	3 chunks	+6 lines, -0 lines	0 comments	Download
A +	base/base64.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
A +	base/base64.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	base/base64_unittest.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chrome_plugin_host.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/convert_user_script.cc	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_creator.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.cc	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extensions_ui.cc	View	1 2 3	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/sandboxed_extension_unpacker.cc	View	1 2	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/gears_integration.cc	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/importer/nss_decryptor.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/metrics/metrics_log.cc	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/safe_browsing/protocol_manager.cc	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_util.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 2 3	4 chunks	+3 lines, -3 lines	0 comments	Download
M	net/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	net/base/data_url.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/base/net_util.cc	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	net/base/sdch_manager.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/base/strict_transport_security_state.cc	View		4 chunks	+3 lines, -3 lines	0 comments	Download
M	net/http/http_auth_handler_basic.cc	View	1 2 3	2 chunks	+6 lines, -4 lines	0 comments	Download
M	net/http/http_auth_handler_ntlm.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/net.gyp	View	1 2 3	4 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. Thanks! http://codereview.chromium.org/399068/diff/2001/2024 File net/http/http_auth_handler_basic.cc (right): http://codereview.chromium.org/399068/diff/2001/2024#newcode50 Line 50: &base64_username_password)) Could you take the opportunity ...

11 years, 1 month ago (2009-11-20 23:09:02 UTC) #3

hayato

11 years, 1 month ago (2009-11-24 06:19:32 UTC) #4

Thank you for the review.

http://codereview.chromium.org/399068/diff/2001/2024
File net/http/http_auth_handler_basic.cc (right):

http://codereview.chromium.org/399068/diff/2001/2024#newcode50
net/http/http_auth_handler_basic.cc:50: &base64_username_password))
Sure. Done.

I also inserted "include <string>" to suppress lint warning.

On 2009/11/20 23:09:02, wtc wrote:
> Could you take the opportunity to align this argument with
> the opening parenthesis '(' for Base64Encode?

Expand Messages | Collapse Messages