Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 399048: linux: pass --gc-sections in link line (Closed)

Created:
11 years, 1 month ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
tony, Craig, agl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: pass --gc-sections in link line We have compile flags set up to support using --gc-sections, but apparently we aren't using it for the actual link! It was probably lost during the gyp conversion. This has a few-megabyte difference on binary size. (Trying submit again, hopefully thestig successfully converted bots...) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
11 years, 1 month ago (2009-11-17 23:23:15 UTC) #1
tony
LG (evan tells me this saves about 4mb!)
11 years, 1 month ago (2009-11-17 23:25:30 UTC) #2
agl
11 years, 1 month ago (2009-11-17 23:25:32 UTC) #3
LGTM

--gc-sections has been enabled at some point in the past. Maybe it got lost when
switching to GYP.

(Also, how much of a size reduction do we get?)

Powered by Google App Engine
This is Rietveld 408576698