Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2912)

Unified Diff: chrome/plugin/plugin_channel_base.h

Issue 399043: Only clears the unblock flag on sync IPCs during other sync dispatches (Closed)
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/plugin/plugin_channel_base.h
diff --git a/chrome/plugin/plugin_channel_base.h b/chrome/plugin/plugin_channel_base.h
index 0263e9b66edeeedda6fae43208dabee8bc49c58f..38bb87bf2fc1c69c1008ce9eaee143329b2a29b6 100644
--- a/chrome/plugin/plugin_channel_base.h
+++ b/chrome/plugin/plugin_channel_base.h
@@ -85,8 +85,8 @@ class PluginChannelBase : public IPC::Channel::Listener,
virtual void OnChannelError();
// If this is set, sync messages that are sent will only unblock the receiver
- // if this channel is in the middle of a dispatch.
- void SendUnblockingOnlyDuringDispatch();
+ // if this channel is in the middle of a sync dispatch.
+ void SendUnblockingOnlyDuringSyncDispatch();
virtual bool Init(MessageLoop* ipc_message_loop, bool create_pipe_now);
@@ -114,13 +114,13 @@ class PluginChannelBase : public IPC::Channel::Listener,
// error. This flag is used to indicate the same.
bool channel_valid_;
- // Track whether we're within a dispatch; works like a refcount, 0 when we're
- // not.
- int in_dispatch_;
+ // Track whether we're within a synchronous dispatch; works like a refcount,
+ // 0 when we're not.
+ int in_sync_dispatch_;
// If true, sync messages will only be marked as unblocking if the channel is
- // in the middle of dispatching a message.
- bool send_unblocking_only_during_dispatch_;
+ // in the middle of dispatching a synchronous message.
+ bool send_unblocking_only_during_sync_dispatch_;
DISALLOW_COPY_AND_ASSIGN(PluginChannelBase);
};

Powered by Google App Engine
This is Rietveld 408576698