Fix race conditions where an object's constructor uses PostTask on itself. T...

views/widget/aero_tooltip_manager.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_WIDGET_AERO_TOOLTIP_MANAGER_H_
 #define VIEWS_WIDGET_AERO_TOOLTIP_MANAGER_H_
 
 #include "base/ref_counted.h"
 #include "base/task.h"
 #include "views/widget/tooltip_manager_win.h"
@@ skipping 22 matching lines @@
 
   virtual void OnMouse(UINT u_msg, WPARAM w_param, LPARAM l_param);
   virtual void OnMouseLeave();
 
  private:
   void Init();
   void OnTimer();
 
   class InitialTimer : public base::RefCounted<InitialTimer> {
    public:
-    InitialTimer(AeroTooltipManager* manager, int time);
+    InitialTimer(AeroTooltipManager* manager);

[jamesr, 2009/11/17 21:00:07]

This needs to be marked explicit

[jam, 2009/11/17 21:03:21]

Done.

+    void Start(int time);
     void Disown();
     void Execute();
 
    private:
     friend class base::RefCounted<InitialTimer>;
 
     ~InitialTimer() {}
 
     AeroTooltipManager* manager_;
   };
 
   int initial_delay_;
   scoped_refptr<InitialTimer> initial_timer_;
 };
 
 }  // namespace views
 
 #endif  // #ifndef VIEWS_WIDGET_AERO_TOOLTIP_MANAGER_H_